apt_dpkg: refactorings for contents cache#594
Open
bdrung wants to merge 3 commits intocanonical:mainfrom
Open
Conversation
Modernize the code by using `pathlib.Path` for `mapping_file`.
`_contents_mapping()` loads the cached content mapping. Calling it multiple times in `_get_file2pkg_mapping` is not needed. Call `_contents_mapping()` before looping over the different pockets of the release.
Move saving the changed contents cache into `_get_file2pkg_mapping` where this contents cache is updated. This improves code locality.
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #594 +/- ##
==========================================
- Coverage 84.45% 84.44% -0.01%
==========================================
Files 104 104
Lines 20939 20938 -1
Branches 3212 3210 -2
==========================================
- Hits 17683 17682 -1
Misses 2815 2815
Partials 441 441 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
These refactorings are preparation for following commits: